Conversation
🦋 Changeset detectedLatest commit: a775667 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review. |
protolambda
force-pushed
the
update-op-geth
branch
from
4f66fbf to
f1ecd2b
Compare
Contributor
|
Do you mind adding a changeset for the |
Contributor
|
I think we may still have to do releases, but maybe you can delete these lines?
|
Contributor
Author
|
@tynes need releases for removing those replace statements first, I still get: pointing to the old library, instead of the new one you introduced in #3880 |
mslipper
approved these changes
Nov 5, 2022
tynes
approved these changes
Nov 5, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update op-geth dependency, rebased to latest
masterbranch. Seeoptimism-historybranch on op-geth repo. The previousoptimism-historycan be found asoptimism-history-nov-4branch.Note: the upstream miner code changed, the background job logic for updating a block specifically. Now that the first tx pool work is fully in the background the sequencer code path needs more room to breathe, or would retrieve empty blocks consistently if it asks for the block building result instantly.
This is something we can optimize later: more time is good, to build better blocks. But less time is better when we are catching up to the latest wallclock time (i.e. when we don't have as much time to wait for production).
For now I increased a few e2e tx inclusion timeouts and added some unconditional breathing time.
Other than that the
trieinterface changed slightly yet again, and we now use eip1559 params via the chain config.Note: endpoint monitor and indexer were also updated from geth v1.10.23 to v1.10.26 to keep them in sync with the upstream base we use for bedrock.